Wikimedia

Pywikibot: (Re)move unused code reported by Vulture (VI)

Pywikibot is a Python-based framework to write bots for MediaWiki (more information).

There are some code pieces that are not used by Pywikibot and a quick scan with vulture creates the output below;

$ python -m vulture ./ --min-confidence 61
scripts/script_wui.py:310: unsatisfiable 'if' condition (100% confidence)
tests/deprecation_tests.py:23: unreachable code after 'raise' (100% confidence)
tests/deprecation_tests.py:34: unreachable code after 'raise' (100% confidence)
tests/deprecation_tests.py:209: unused variable 'foo3' (100% confidence)
tests/deprecation_tests.py:209: unused variable 'foo4' (100% confidence)

Setup Pywikibot locally and remove these unused codes. It will be also useful to recheck this report with vulture and also before making a patch, run unit tests to make sure no regressions have been introduced.

Acceptance Criteria

Task tags

  • python
  • cleanup
  • vulture
  • pywikibot

Students who completed this task

YVB

Task type

  • code Code
  • done_all Quality Assurance
close

2018