Wikimedia

Enable and fix violations for 3 eslint rules

Before beginning this task, you should have set up a development environment https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/docs/setup.md

The Wiki Education Dashboard has a React.js frontend. Javascript style conventions are enforced using eslint, the airbnb basic config, and several plugins. Some rules are disabled, because we have not yet brought the codebase in line with those rules: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/.eslintrc

The goal of this task is to enable more of these rules and fix any violations. To complete it:

  1. ) Choose a rule from the below the comment # Rules below here should be enabled once violations are fixed in the config, look up that rule to understand its purpose and the details of what it does, and then delete the line that disables that rule.
  2. ) Run the linter to see the list of violations. (Running gulp is one way to do this.)
  3. ) Fix any violations of the rule. Alternatively, if you think following the rule will make the codebase worse, move the rule to above the should be enabled comment.
  4. ) Create a commit with the change to .eslintrc and all the corresponding fixes to Javascript and JSX files. Describe the purpose of the rule in the commit message (and why it should not be enabled, if you think it should become a permanent exception).
  5. ) Repeat this for 2 additional rules.
  6. ) Open a pull request with these 3 commits.

Task tags

  • react
  • javascript
  • wiki-edu-dashboard
  • linting

Students who completed this task

arcaynia, takidelfin

Task type

  • code Code
close

2018